Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssessmentComment model change for longer comments #2374

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

emi-hi
Copy link
Collaborator

@emi-hi emi-hi commented Dec 10, 2024

-updates assessment Comment model to allow for longer comment lengths (textField)

@emi-hi emi-hi requested a review from JulianForeman December 10, 2024 01:27
@tim738745 tim738745 merged commit d8a36d2 into bcgov:release-1.65.0 Jan 2, 2025
2 checks passed
kuanfandevops added a commit that referenced this pull request Feb 6, 2025
* fix: convert carry over deficits (#2360)
* fix: adds check for comments before rendering div with outline so there isnt an empty box when agreements dont have comments (#2359)
* chore: modifies proptypes in vehicle supplier tabs due to console messages appearing
* 2292 unit-tests: Compliance Obligation Container (#2367)
* feat: adds separation between sales/suppled on vehicle supplier information page (#2369)
* feat: 2364 - add tooltips (#2368)
* 1732, 1734 - Unit-tests for Compliance and Compliance/components (#2372)
* fix: 2362 - deficits (#2371)
* fix: replaces reportYear with modelYear so page can load properly (uncaught reference error) (#2378)
* task: 2363 Flagging Duplicate VINs in BCeID Spreadsheet Uploads to Prevent Error 31 (duplicate VINs) (#2370)
* task: spreadsheets with duplicate vins are rejected with error message during submission
* chore: moves line out of loop
* updates assessment Comment model to allow for longer comment lengths (textField) (#2374)
* ZEVA-1744: Unit tests for 3 supplementary components  (#2375)
* task: 2338 - credit transaction tabs on credit agreement details pages (#2377)
* -adds navigation tabs to credit agreement details
* chore: ran prettier
* tests for utils (#2379)
* fix: changes sales input to be numerical instead of text to reduce user error (#2404)
* chore: adds tests for vehicle viewset (#2405)
* 2380 Disable Transaction Page "Save" Button (#2406)
* Disable Save button if vehicle supplier, transaction type, or effective date is not entered.
* Disable "Submit to Director" button if credit quantity is missing.
* Remove unwanted zero in LDV sales/supplied. (#2407)
* 2339 - Fix tab/stage-name inconsistency during loading issue (#2402)
* Add model-year in query string to solve tab-names inconsistency during loading issue.
* Add URI encoding and code clean-up
* Align compliance report tabs
* Fixing compliance report disabled tabs alignment
* Disable compliance-report tabs when loading.
* Move insertIdAndYear function to utilities
* feat: 2373 - adds separate comment box for reject/request changes (#2401)
* feat: initial changes to seperate comment boxes and add tooltip
* chore: ran prettier
* chore: minor refactoring
* chore: adds useEffect
* Setting page-size as maximum number of rows to be displayed in VIN-list-table (#2411)
* update frontend builder image to node 20.18.1
* feat: 2409 -  disables save button if forecast isn't filled, adds tooltip (#2414)
* feat: disables save button if forecast isn't filled, adds tooltip
* fix: adds check for model year before disabling save
* chore: adds proptypes
* add unit tests for creditagreement components (#2395)
* fix: 2408 - confirmation checkbox for sales forecast (#2416)
* fix: conditionally displays confirmation for sales forecast if year >= 2023
* chore: adds proptypes
* chore: replaces if-then-else flow as requested by sonarcloud
* fix failing tests (#2421)

* ZEVA-2290: Forecast upload notification improvement (#2418)

* enhance ux on file upload

* allow for prescence of confirm modal to be controlled via props for FileDropArea

* adds script, instructions for running new scripts to insert data and update users (#2422)

* 1738: Create unit-tests for Credits (#2417)

* Create unit-tests for Credits

* Grouping common test data

* ZEVA-1736: Unit tests for credit agreement components (#2424)

* unit tests for credit agreement components

* reduce duplicate code

* feat: 2412 - updated sales and supplied table (#2425)

* feat: 2412 - updated sales and supplied table

* small change

* fix: 2428 - credit transfer submission date (#2431)

* more unit tests (#2430)

* 2426/2423 - Tooltips (#2432)

* feat: adds tooltip component and implements it on supplier info page and compliance obligation

* chore: linting

* chore: more linting

* fix: adds # to css color

* chore: 2347 - credit agreement backend tests (#2435)

* fix: adds filter to credit agreement comments for bceid users

* adds check to ensure comment exists for update

* chore: credit agreement tests

* chore: linting

* 2427 - Mandatory comment in credit transfer recommendation (#2437)

* Disable Recommend buttons in credit transfer if no comment is entered.

* Fix props-validation

* Disable "Add Comment" button until a comment is entered.

* Fix the issue that some buttons won't change back to disabled if comment is erased.

* 2415 - Function for Resetting the Database (#2429)

* Add admin command reset_database

* minor change

* Add migration and check for production environment

* icbc ver tests (#2442)

* ZEVA-2329:  Credit transfer unit tests (#2438)

* credit transfer tests

* more debug

* ensure users get distinct organizations

* remove transaction.oncommit

---------

Co-authored-by: Emily <[email protected]>
Co-authored-by: Roger Leung <[email protected]>
Co-authored-by: tim738745 <[email protected]>
Co-authored-by: Jonny Toombs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants